Overall LGTM.
http://codereview.chromium.org/6010/diff/1/2 File tools/test.py (right): http://codereview.chromium.org/6010/diff/1/2#newcode60 Line 60: self.queue.put_nowait(case) Do you really want put_nowait, and not just put() ? http://codereview.chromium.org/6010/diff/1/2#newcode79 Line 79: def WithLock(self, fun): This can questionable be written easier with a generator: from __future__ import generators def WithLock(self): self.lock.acquire() yield self.lock.release() for blah in self.WithLock(): // Will get executed once while holding the lock http://codereview.chromium.org/6010/diff/1/2#newcode99 Line 99: # swallowed during 'join'. Comment would be better as: # Use a timeout so that signals (ctrl-c) will be processed. http://codereview.chromium.org/6010/diff/1/2#newcode1026 Line 1026: default=1) type="int" ? http://codereview.chromium.org/6010/diff/1/2#newcode1216 Line 1216: if RunTestCases(all_cases, options.progress, int(options.j)): Do you need this if you do type="int" ? http://codereview.chromium.org/6010 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
