On Mon, Oct 27, 2008 at 4:02 AM, <[EMAIL PROTECTED]> wrote: > Drive by comment: > > > http://codereview.chromium.org/7990/diff/201/206 > File src/array.js (right): > > http://codereview.chromium.org/7990/diff/201/206#newcode376 > Line 376: // TODO: can we just use arguments? > I think it would work fine with using 'arguments'. You probably have to > pass in the receiver (this) to the %ArrayConcat call as the first > parameter, but it should work and it should be a lot faster than the > current code.
Passing 'arguments' to %ArrayConcat didn't work as simple as we thought. That's why I put a TODO there. I didn't spend much time on tracing why 'arguments' didn't work. > > http://codereview.chromium.org/7990 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
