LGTM -Ivan
http://codereview.chromium.org/8830/diff/1/3 File src/simulator-arm.cc (right): http://codereview.chromium.org/8830/diff/1/3#newcode444 Line 444: PrintF("Unaligned read at %x\n", addr); It would be helpful to print the PC and the address in the failure messages such as: "Unaligned read from %x at %x\n" http://codereview.chromium.org/8830/diff/1/3#newcode483 Line 483: void Simulator::WriteH(int32_t addr, uint16_t value) { The two WriteH and WriteB variants are really hard to distinguish, but I do not have a better suggestion for you either. Maybe a comment would help? http://codereview.chromium.org/8830/diff/1/3#newcode506 Line 506: uint8_t* ptr = reinterpret_cast<uint8_t*>(addr); Why no alignment check here? ;-) http://codereview.chromium.org/8830 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
