Thanks for the feedback. Applied the changes, made it lint and now I am running more tests...
-Ivan http://codereview.chromium.org/8835/diff/1/12 File src/codegen-ia32.cc (right): http://codereview.chromium.org/8835/diff/1/12#newcode817 Line 817: flags = ((loop_nesting_ > 0) && type->IsLikelySmi()) ? SMI_CODE_INLINED : Done. On 2008/10/28 15:25:39, Kasper Lund wrote: > Nit: I would move ? onto a new line and : onto yet another new line, like > > x = <complicated boolean expression> > ? <blah> > : <argh>; http://codereview.chromium.org/8835/diff/1/5 File src/variables.h (right): http://codereview.chromium.org/8835/diff/1/5#newcode83 Line 83: static char* Type2String(StaticType* type) { Done. On 2008/10/28 15:25:39, Kasper Lund wrote: > I would move this to a .cc file. http://codereview.chromium.org/8835/diff/1/5#newcode95 Line 95: // LIKELY_SMI accessors Changed to SetAsLikelySmi which to me implies that it is a setter while not necessarily expecting an argument (the argument is really a part of the function name). On 2008/10/28 15:25:39, Kasper Lund wrote: > How about MarkAsLikelySmi? Set sounds like something that takes an argument... http://codereview.chromium.org/8835 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
