Mostly a rubber stamp LGTM. In the future, it would be great if you could upload a new patch set (just do gcl upload again) instead of creating a new CL. That makes it easier to preserve comments across reviews and makes it easier to see the diff between patch sets. Comments:
http://codereview.chromium.org/8831/diff/209/16 File src/mark-compact.cc (right): http://codereview.chromium.org/8831/diff/209/16#newcode332 Line 332: // ASSERT(!obj->IsMap()); // Some maps are processed here. We shouldn't need to carry code in comments. I guess the assertion doesn't hold anymore? http://codereview.chromium.org/8831/diff/209/14 File src/objects.h (right): http://codereview.chromium.org/8831/diff/209/14#newcode1050 Line 1050: static inline Object* &RawField(HeapObject* obj, int offset); This looks nasty with returning a reference. Can't you rewrite this with a RawFieldGet and RawFieldSet? http://codereview.chromium.org/8831 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
