On the V8 benchmark: bytes emitted (--log-code): before 451007 after 446262
So about a 1% code size improvement. -- dean On Sun, Nov 9, 2008 at 10:18 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Message: > There is a bit of duplication for the mov(reg, reg), since it could have > used one of the Operand() versions, but using Operand() for bare > registers feels strange and is often unclear which encoding will be > used... > > Description: > Use shorting encoding for mov REG, IMM. Use Set() in two places to take > generate smaller code when the immediate is 0. > > Please review this at http://codereview.chromium.org/10002 > > Affected files: > M src/assembler-ia32.h > M src/assembler-ia32.cc > M src/builtins-ia32.cc > M src/codegen-ia32.cc > M src/ic-ia32.cc > M src/macro-assembler-ia32.cc > M src/stub-cache-ia32.cc > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
