Comments from left field. -Ivan
PS. Otherwise LGTM and thanks for the cleanup. http://codereview.chromium.org/11406/diff/1/4 File src/virtual-frame-arm.cc (right): http://codereview.chromium.org/11406/diff/1/4#newcode46 Line 46: frame_pointer_(-1) { Ideally you could define an illegal index and use that wherever the VirtualFrame has not yet been setup and in other similar situations. http://codereview.chromium.org/11406/diff/1/4#newcode111 Line 111: Adjust(4); Can you please document the magic numbers in this file? I assume 4 is the size of the arm native stack frame. A simple comment referring to the line below would do. http://codereview.chromium.org/11406 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
