Changed oring ot merging in comment. On Wed, Nov 19, 2008 at 11:00 AM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Christian Plesner Hansen, > > Description: > Changed the handling of Win32 function SetErrorMode to be more correct. > The flag to prevent error dialogs is now merged with existing flags, and > the error mode is now reset which it was not before. > > Please review this at http://codereview.chromium.org/11471 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M tools/test.py > > > Index: tools/test.py > =================================================================== > --- tools/test.py (revision 787) > +++ tools/test.py (working copy) > @@ -417,8 +417,12 @@ > if utils.IsWindows(): > popen_args = '"' + subprocess.list2cmdline(args) + '"' > if context.suppress_dialogs: > - # Try to change the error mode to avoid dialogs on fatal errors. > - Win32SetErrorMode(SEM_NOGPFAULTERRORBOX) > + # Try to change the error mode to avoid dialogs on fatal errors. > Don't > + # touch any existing error mode flags by oring in the existing error > mode. > + # See > http://blogs.msdn.com/oldnewthing/archive/2004/07/27/198410.aspx. > + error_mode = SEM_NOGPFAULTERRORBOX; > + prev_error_mode = Win32SetErrorMode(error_mode); > + Win32SetErrorMode(error_mode | prev_error_mode); > process = subprocess.Popen( > shell = utils.IsWindows(), > args = popen_args, > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
