Lgtm
http://codereview.chromium.org/12473/diff/1/4 File src/jsregexp.cc (right): http://codereview.chromium.org/12473/diff/1/4#newcode476 Line 476: //PrintF("\n\nSubject string: '%s'\n\n", *(two_byte_subject->ToCString())); Either comment it back in or remove it. http://codereview.chromium.org/12473/diff/1/3 File src/jsregexp.h (right): http://codereview.chromium.org/12473/diff/1/3#newcode745 Line 745: explicit Analysis(bool case_independent) We're somewhat inconsistent in what we call this: case_independent, ignore_case, etc. We should settle on just one and I vote for ignore_case. http://codereview.chromium.org/12473 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
