Reviewers: Christian Plesner Hansen, Message: Bugfix review
Description: Builds on Windows too. Please review this at http://codereview.chromium.org/12864 Affected files: M src/runtime.cc Index: src/runtime.cc diff --git a/src/runtime.cc b/src/runtime.cc index 5512f8323a99e42769fff93167d07ce64693fec0..749bee087774d770f10f7dc92cde8ec03f785383 100644 --- a/src/runtime.cc +++ b/src/runtime.cc @@ -1383,13 +1383,14 @@ int Runtime::StringMatch(Handle<String> sub, } Vector<const char> ascii_vector = sub->ToAsciiVector().SubVector(start_index, subject_length); - void* pos = memchr(ascii_vector.start(), - static_cast<const char>(pchar), - static_cast<size_t>(ascii_vector.length())); + const void* pos = memchr(ascii_vector.start(), + static_cast<const char>(pchar), + static_cast<size_t>(ascii_vector.length())); if (pos == NULL) { return -1; } - return reinterpret_cast<char*>(pos) - ascii_vector.start() + start_index; + return reinterpret_cast<const char*>(pos) - ascii_vector.start() + + start_index; } return SingleCharIndexOf(sub->ToUC16Vector(), pat->Get(pat_shape, 0), --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---