Reviewers: Kevin Millikin, Message: Here are a few lint fixes. I know you are removing the TODO anyway.
Description: Fix lint errors - spacing and formatting. Please review this at http://codereview.chromium.org/14193 SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ Affected files: M src/codegen-ia32.h M src/codegen-ia32.cc M src/jump-target-arm.cc M src/register-allocator-ia32.h M src/virtual-frame-arm.h Index: src/codegen-ia32.h =================================================================== --- src/codegen-ia32.h (revision 991) +++ src/codegen-ia32.h (working copy) @@ -83,8 +83,8 @@ void GetValue(TypeofState typeof_state); // Generate code to push the value of a reference on top of the expression - // stack and then spill the stack frame. This function is used temporarily while - // the code generator is being transformed. + // stack and then spill the stack frame. This function is used temporarily + // while the code generator is being transformed. inline void GetValueAndSpill(TypeofState typeof_state); // Generate code to store the value on top of the expression stack in the Index: src/register-allocator-ia32.h =================================================================== --- src/register-allocator-ia32.h (revision 991) +++ src/register-allocator-ia32.h (working copy) @@ -81,7 +81,7 @@ class RegisterAllocator BASE_EMBEDDED { public: - RegisterAllocator(CodeGenerator* cgen) : code_generator_(cgen) {} + explicit RegisterAllocator(CodeGenerator* cgen) : code_generator_(cgen) {} int num_registers() const { return RegisterFile::kNumRegisters; } Index: src/virtual-frame-arm.h =================================================================== --- src/virtual-frame-arm.h (revision 991) +++ src/virtual-frame-arm.h (working copy) @@ -56,7 +56,7 @@ // as random access to the expression stack elements, locals, and // parameters. -class VirtualFrame : public Malloced{ +class VirtualFrame : public Malloced { public: // Construct a virtual frame with the given code generator used to // generate code. Index: src/codegen-ia32.cc =================================================================== --- src/codegen-ia32.cc (revision 991) +++ src/codegen-ia32.cc (working copy) @@ -571,7 +571,8 @@ // ECMA-262, section 9.2, page 30: ToBoolean(). Pop the top of stack and // convert it to a boolean in the condition code register or jump to // 'false_target'/'true_target' as appropriate. -void CodeGenerator::ToBoolean(JumpTarget* true_target, JumpTarget* false_target) { +void CodeGenerator::ToBoolean(JumpTarget* true_target, + JumpTarget* false_target) { Comment cmnt(masm_, "[ ToBoolean"); // The value to convert should be popped from the stack. @@ -4067,8 +4068,8 @@ // Uncommon case: typeof testing against a string literal that is // never returned from the typeof operator. false_target()->Jump(); - // TODO(): Can this cause a problem because it is an expression that - // exits without a virtual frame in place? + // TODO(kmilliken) : Can this cause a problem because it is an expression + // that exits without a virtual frame in place? } return; } Index: src/jump-target-arm.cc =================================================================== --- src/jump-target-arm.cc (revision 991) +++ src/jump-target-arm.cc (working copy) @@ -130,7 +130,7 @@ ASSERT(expected_frame_ == NULL); expected_frame_ = new VirtualFrame(current_frame); - // Adjust the expected frame's height to account for the return address + // Adjust the expected frame's height to account for the return address // pushed by the call instruction. expected_frame_->Adjust(1); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
