I concur with Erik. The function should return int instead. I'll fix it (since it was my mistake to begin with).
On Mon, Jan 12, 2009 at 8:35 PM, Erik Corry <erikco...@google.com> wrote: > LGTM > > (though I'd prefer a change that made char_size() return an int. It seems > to me that size_t always causes problems and in this case it's either 1 or 2 > so int is 'very likely' to cover the required range) > > On Mon, Jan 12, 2009 at 4:17 PM, <whe...@chromium.org> wrote: > >> >> >> Reviewers: plesner, >> >> Message: >> Windows needs a type cast that Linux doesn't. Here it is. >> >> Description: >> Fixes Windows compiler warning about unary minus applied to unsigned >> int. >> >> Please review this at http://codereview.chromium.org/17609 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M src/regexp-macro-assembler-ia32.cc >> >> >> Index: src/regexp-macro-assembler-ia32.cc >> =================================================================== >> --- src/regexp-macro-assembler-ia32.cc (revision 1053) >> +++ src/regexp-macro-assembler-ia32.cc (working copy) >> @@ -665,7 +665,7 @@ >> const int kRegisterZeroEBPOffset = -1; >> __ mov(ecx, kRegisterZeroEBPOffset); >> // Set eax to address of char before start of input. >> - __ lea(eax, Operand(edi, -char_size())); >> + __ lea(eax, Operand(edi, -static_cast<int32_t>(char_size()))); >> Label init_loop; >> __ bind(&init_loop); >> __ mov(Operand(ebp, ecx, times_4, +0), eax); >> >> >> >> >> > > > -- > Erik Corry, Software Engineer > Google Denmark ApS. CVR nr. 28 86 69 84 > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen > K, Denmark. > > > > -- Lasse R.H. Nielsen l...@google.com 'Faith without judgement merely degrades the spirit divine' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
