LGTM On Wed, Jan 14, 2009 at 12:49 PM, <christian.plesner.han...@gmail.com>wrote:
> Reviewers: Lasse Reichstein, > > Description: > Fixed test failure caused by being more conservative in estimating the > length of expressions containing backreferences. Bad plesner for > forgetting to run the tests before submitting! > > Please review this at http://codereview.chromium.org/18043 > > Affected files: > M test/cctest/test-regexp.cc > > > Index: test/cctest/test-regexp.cc > diff --git a/test/cctest/test-regexp.cc b/test/cctest/test-regexp.cc > index > 6e61514396f8285156ba3e14dc858b31344f0cc1..4383209f8e5226d1a0eeac1bd3b464fd5ee4a17e > 100644 > --- a/test/cctest/test-regexp.cc > +++ b/test/cctest/test-regexp.cc > @@ -291,8 +291,8 @@ TEST(Parser) { > CHECK_MIN_MAX("(?:ab)|cde", 2, 3); > CHECK_MIN_MAX("(ab)", 2, 2); > CHECK_MIN_MAX("(ab|cde)", 2, 3); > - CHECK_MIN_MAX("(ab)\\1", 4, 4); > - CHECK_MIN_MAX("(ab|cde)\\1", 4, 6); > + CHECK_MIN_MAX("(ab)\\1", 2, 4); > + CHECK_MIN_MAX("(ab|cde)\\1", 2, 6); > CHECK_MIN_MAX("(?:ab)?", 0, 2); > CHECK_MIN_MAX("(?:ab)*", 0, RegExpTree::kInfinity); > CHECK_MIN_MAX("(?:ab)+", 2, RegExpTree::kInfinity); > > > -- Lasse R.H. Nielsen l...@google.com 'Faith without judgement merely degrades the spirit divine' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
