Reviewers: Mads Ager, Description: Push bleeding_e...@1391 and bleeding_e...@1392 to trunk.
Please review this at http://codereview.chromium.org/27325 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M src/api.cc M src/log.cc M src/regexp-delay.js M test/mjsunit/regexp-static.js Index: test/mjsunit/regexp-static.js =================================================================== --- test/mjsunit/regexp-static.js (revision 1393) +++ test/mjsunit/regexp-static.js (working copy) @@ -132,3 +132,8 @@ re = /(.)/g; function f() { return RegExp.$1; }; assertEquals('abcd', 'abcd'.replace(re, f)); + +RegExp.multiline = "foo"; +assertTrue(typeof RegExp.multiline == typeof Boolean(), "RegExp.multiline coerces values to booleans"); +RegExp.input = Number(); +assertTrue(typeof RegExp.input == typeof String(), "RegExp.input coerces values to booleans"); Index: src/api.cc =================================================================== --- src/api.cc (revision 1393) +++ src/api.cc (working copy) @@ -2185,7 +2185,7 @@ const char* v8::V8::GetVersion() { - return "1.0.3"; + return "1.0.3.1"; } Index: src/regexp-delay.js =================================================================== --- src/regexp-delay.js (revision 1393) +++ src/regexp-delay.js (working copy) @@ -318,7 +318,8 @@ return IS_UNDEFINED(regExpInput) ? "" : regExpInput; } function RegExpSetInput(string) { - lastMatchInfo[lastMatchInfo[REGEXP_NUMBER_OF_CAPTURES] + 2] = string; + lastMatchInfo[lastMatchInfo[REGEXP_NUMBER_OF_CAPTURES] + 2] = + ToString(string); }; %DefineAccessor($RegExp, 'input', GETTER, RegExpGetInput, DONT_DELETE); Index: src/log.cc =================================================================== --- src/log.cc (revision 1393) +++ src/log.cc (working copy) @@ -386,7 +386,9 @@ // Write the log message to the log file currently opened. void LogMessageBuilder::WriteToLogFile() { ASSERT(pos_ <= Logger::kMessageBufferSize); - fwrite(Logger::message_buffer_, 1, pos_, Logger::logfile_); + size_t rv = fwrite(Logger::message_buffer_, 1, pos_, Logger::logfile_); + ASSERT(rv == static_cast<size_t>(pos_)); + USE(rv); } #endif --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
