Author: [email protected]
Date: Wed Mar 4 02:33:00 2009
New Revision: 1414
Modified:
branches/bleeding_edge/src/platform-freebsd.cc
branches/bleeding_edge/src/platform-linux.cc
branches/bleeding_edge/src/platform-macos.cc
branches/bleeding_edge/src/platform-win32.cc
branches/bleeding_edge/src/platform.h
branches/bleeding_edge/test/cctest/test-sockets.cc
Log:
The SendAll method on Socket was a helper method that did not really belong
in platform.
Review URL: http://codereview.chromium.org/40104
Modified: branches/bleeding_edge/src/platform-freebsd.cc
==============================================================================
--- branches/bleeding_edge/src/platform-freebsd.cc (original)
+++ branches/bleeding_edge/src/platform-freebsd.cc Wed Mar 4 02:33:00 2009
@@ -656,7 +656,6 @@
// Data Transimission
int Send(const char* data, int len) const;
- bool SendAll(const char* data, int len) const;
int Receive(char* data, int len) const;
bool IsValid() const { return socket_ != -1; }
@@ -733,19 +732,6 @@
int FreeBSDSocket::Send(const char* data, int len) const {
int status = send(socket_, data, len, 0);
return status;
-}
-
-
-bool FreeBSDSocket::SendAll(const char* data, int len) const {
- int sent_len = 0;
- while (sent_len < len) {
- int status = Send(data, len);
- if (status <= 0) {
- return false;
- }
- sent_len += status;
- }
- return true;
}
Modified: branches/bleeding_edge/src/platform-linux.cc
==============================================================================
--- branches/bleeding_edge/src/platform-linux.cc (original)
+++ branches/bleeding_edge/src/platform-linux.cc Wed Mar 4 02:33:00 2009
@@ -640,7 +640,6 @@
// Data Transimission
int Send(const char* data, int len) const;
- bool SendAll(const char* data, int len) const;
int Receive(char* data, int len) const;
bool IsValid() const { return socket_ != -1; }
@@ -717,19 +716,6 @@
int LinuxSocket::Send(const char* data, int len) const {
int status = send(socket_, data, len, 0);
return status;
-}
-
-
-bool LinuxSocket::SendAll(const char* data, int len) const {
- int sent_len = 0;
- while (sent_len < len) {
- int status = Send(data, len);
- if (status <= 0) {
- return false;
- }
- sent_len += status;
- }
- return true;
}
Modified: branches/bleeding_edge/src/platform-macos.cc
==============================================================================
--- branches/bleeding_edge/src/platform-macos.cc (original)
+++ branches/bleeding_edge/src/platform-macos.cc Wed Mar 4 02:33:00 2009
@@ -607,7 +607,6 @@
// Data Transimission
int Send(const char* data, int len) const;
- bool SendAll(const char* data, int len) const;
int Receive(char* data, int len) const;
bool IsValid() const { return socket_ != -1; }
@@ -690,19 +689,6 @@
int MacOSSocket::Send(const char* data, int len) const {
int status = send(socket_, data, len, 0);
return status;
-}
-
-
-bool MacOSSocket::SendAll(const char* data, int len) const {
- int sent_len = 0;
- while (sent_len < len) {
- int status = Send(data, len);
- if (status <= 0) {
- return false;
- }
- sent_len += status;
- }
- return true;
}
Modified: branches/bleeding_edge/src/platform-win32.cc
==============================================================================
--- branches/bleeding_edge/src/platform-win32.cc (original)
+++ branches/bleeding_edge/src/platform-win32.cc Wed Mar 4 02:33:00 2009
@@ -1583,7 +1583,6 @@
// Data Transimission
int Send(const char* data, int len) const;
- bool SendAll(const char* data, int len) const;
int Receive(char* data, int len) const;
bool IsValid() const { return socket_ != INVALID_SOCKET; }
@@ -1660,19 +1659,6 @@
int Win32Socket::Send(const char* data, int len) const {
int status = send(socket_, data, len, 0);
return status;
-}
-
-
-bool Win32Socket::SendAll(const char* data, int len) const {
- int sent_len = 0;
- while (sent_len < len) {
- int status = Send(data, len);
- if (status <= 0) {
- return false;
- }
- sent_len += status;
- }
- return true;
}
Modified: branches/bleeding_edge/src/platform.h
==============================================================================
--- branches/bleeding_edge/src/platform.h (original)
+++ branches/bleeding_edge/src/platform.h Wed Mar 4 02:33:00 2009
@@ -437,7 +437,6 @@
// Data Transimission
virtual int Send(const char* data, int len) const = 0;
- virtual bool SendAll(const char* data, int len) const = 0;
virtual int Receive(char* data, int len) const = 0;
virtual bool IsValid() const = 0;
Modified: branches/bleeding_edge/test/cctest/test-sockets.cc
==============================================================================
--- branches/bleeding_edge/test/cctest/test-sockets.cc (original)
+++ branches/bleeding_edge/test/cctest/test-sockets.cc Wed Mar 4 02:33:00
2009
@@ -63,6 +63,19 @@
}
+static bool SendAll(Socket* socket, const char* data, int len) {
+ int sent_len = 0;
+ while (sent_len < len) {
+ int status = socket->Send(data, len);
+ if (status <= 0) {
+ return false;
+ }
+ sent_len += status;
+ }
+ return true;
+}
+
+
static void SendAndReceive(char *data, int len) {
bool ok;
@@ -78,7 +91,7 @@
CHECK(ok);
// Send all the data.
- ok = client->SendAll(data, len);
+ ok = SendAll(client, data, len);
CHECK(ok);
// Wait until data is received.
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
