Reviewers: Mads Ager, Description: Fixed issue 253. No longer assuming that the target of a property lookup is a JSObject.
Please review this at http://codereview.chromium.org/39126 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/runtime.cc A test/mjsunit/regress/regress-253.js Index: test/mjsunit/regress/regress-253.js =================================================================== --- test/mjsunit/regress/regress-253.js (revision 0) +++ test/mjsunit/regress/regress-253.js (revision 0) @@ -0,0 +1,31 @@ +// Copyright 2009 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +var x = 0; +assertEquals(0, x[0] = 0); +assertEquals(1, x[0] = 1); +assertEquals(2, x[0] = 2); Index: src/runtime.cc =================================================================== --- src/runtime.cc (revision 1400) +++ src/runtime.cc (working copy) @@ -2164,16 +2164,22 @@ static Object* Runtime_ToFastProperties(Arguments args) { ASSERT(args.length() == 1); - CONVERT_ARG_CHECKED(JSObject, object, 0); - object->TransformToFastProperties(0); + Handle<Object> object = args.at<Object>(0); + if (object->IsJSObject()) { + Handle<JSObject> js_object = Handle<JSObject>::cast(object); + js_object->TransformToFastProperties(0); + } return *object; } static Object* Runtime_ToSlowProperties(Arguments args) { ASSERT(args.length() == 1); - CONVERT_ARG_CHECKED(JSObject, object, 0); - object->NormalizeProperties(CLEAR_INOBJECT_PROPERTIES); + Handle<Object> object = args.at<Object>(0); + if (object->IsJSObject()) { + Handle<JSObject> js_object = Handle<JSObject>::cast(object); + js_object->NormalizeProperties(CLEAR_INOBJECT_PROPERTIES); + } return *object; } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
