LGTM
http://codereview.chromium.org/39124/diff/19/1003 File src/debug.h (right): http://codereview.chromium.org/39124/diff/19/1003#newcode361 Line 361: // Preemption happened while debugging full stop http://codereview.chromium.org/39124/diff/19/1003#newcode553 Line 553: // Make sure that premption does not occour while handling the break point. Spolling in too places. http://codereview.chromium.org/39124/diff/19/1003#newcode559 Line 559: } Seems like this part is not needed. If a preemption is pending then it will hit immediately JS is resumed and it will set the preemption pending flag in execution.cc. http://codereview.chromium.org/39124 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
