LGTM. On Fri, Mar 13, 2009 at 9:22 AM, <[email protected]> wrote: > > Reviewers: Kasper Lund, > > Description: > Push the change to not leak reaching frames in case of stack overflows > to trunk. > > Please review this at http://codereview.chromium.org/42172 > > SVN Base: http://v8.googlecode.com/svn/trunk/ > > Affected files: > M src/api.cc > M src/jump-target.cc > > > Index: src/api.cc > =================================================================== > --- src/api.cc (revision 1501) > +++ src/api.cc (working copy) > @@ -2200,7 +2200,7 @@ > > > const char* v8::V8::GetVersion() { > - return "1.1.1"; > + return "1.1.1.1"; > } > > > Index: src/jump-target.cc > =================================================================== > --- src/jump-target.cc (revision 1501) > +++ src/jump-target.cc (working copy) > @@ -74,11 +74,9 @@ > // to them. In the event of a compile-time stack overflow or an > // unitialized jump target, we don't care. > ASSERT(!is_linked() || cgen_ == NULL || cgen_->HasStackOverflow()); > -#ifdef DEBUG > for (int i = 0; i < reaching_frames_.length(); i++) { > - ASSERT(reaching_frames_[i] == NULL); > + delete reaching_frames_[i]; > } > -#endif > delete entry_frame_; > > Reset(); > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
