Other than the issue mentioned below, it LGTM.
http://codereview.chromium.org/42565/diff/1004/1008 File src/virtual-frame.cc (right): http://codereview.chromium.org/42565/diff/1004/1008#newcode189 Line 189: // in the CodeGenerator's Allocator must be above 0. I don't like this comment. It's not really a true precondition (the function still works fine otherwise), and if it were a precondition it shouldn't be buried here in the implementation. http://codereview.chromium.org/42565 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
