http://codereview.chromium.org/56185/diff/1/4
File src/compilation-cache.cc (right):

http://codereview.chromium.org/56185/diff/1/4#newcode101
Line 101: // script originates from the same places. This is to avoid
issues
On 2009/04/02 18:24:16, iposva wrote:
> places -> place?

Done.

http://codereview.chromium.org/56185/diff/1/4#newcode105
Line 105: // when reporting errors, etc.
On 2009/04/02 18:24:16, iposva wrote:
> Duplicated comment.

Done.

http://codereview.chromium.org/56185/diff/1/4#newcode148
Line 148: int column_offset) {
Done, but the details are slightly different. We won't share code
accidentally across contexts, but if a second identical script is
compiled (from a different source / line) it won't use the cached copy
and won't be cached itself.

http://codereview.chromium.org/56185

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to