> Is there a way where you can ASSERT if the caller's SP is accessed in > this mode?
There is no problem in accessing it, the only problem is that it will be shifted, so you can't trust it. I have tests for profiler's stack tracing, that remain working OK after this change. On Tue, Apr 14, 2009 at 03:16, <[email protected]> wrote: > Small comment to be addressed in a new change list may be. Otherwise > LGTM. > > -Ivan > > > > > http://codereview.chromium.org/73020/diff/8/13 > File src/frames.h (right): > > http://codereview.chromium.org/73020/diff/8/13#newcode422 > Line 422: // A shortcoming is that caller's SP value will be calculated > incorrectly > Is there a way where you can ASSERT if the caller's SP is accessed in > this mode? > > http://codereview.chromium.org/73020 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
