2009/4/23 Søren Gjesse <[email protected]> > What about removing the -ia32 and -arm suffixes would that be to dangerous? >
I'd prefer not. It's nice to have project-wide unique filenames. > > You are missing the file tools/visual_studio/v8_base_arm.vcproj. > > /Søren > > > On Thu, Apr 23, 2009 at 10:41, <[email protected]> wrote: > >> >> This sounds reasonable. There are a few issues as discussed: >> >> 1. Be 100% sure that these files are moved with 'svn move' so svn will >> not get confused by this (and make merging between versions hard). >> >> 2. We should use includes that are relative to the src directory. In >> the backend specific files, it would be nicer to have #include >> "ia32/file-ia32.h" instead of "../file-ia32.h". >> >> 3. Once this is landed, we need to fix the chromium build system so we >> can push that fix to chromium when this new V8 version is pushed to >> chromium. >> >> http://codereview.chromium.org/92068 >> >> >> > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
