LGTM This is a hack and we should revisit it, but as a temporary solution to make the NPObject construct calls work, I'm ok with this.
http://codereview.chromium.org/60035/diff/1/3 File src/builtins-ia32.cc (right): http://codereview.chromium.org/60035/diff/1/3#newcode309 Line 309: __ xor_(ebx, Operand(ebx)); Add a comment that this is setting the arguments count to zero? http://codereview.chromium.org/60035/diff/1/2 File test/cctest/test-api.cc (left): http://codereview.chromium.org/60035/diff/1/2#oldcode4561 Line 4561: // Try something that will cause an exception: Call the object as a Please add a test case for the intended behavior of construct calls. http://codereview.chromium.org/60035 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
