LGTM 2009/4/28 <[email protected]>
> Reviewers: Erik Corry, > > Description: > Add stubbed-out versions of missing member functions on ARM. > > [email protected] > > > Please review this at http://codereview.chromium.org/99123 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/ic-arm.cc > > > Index: src/arm/ic-arm.cc > =================================================================== > --- src/arm/ic-arm.cc (revision 1805) > +++ src/arm/ic-arm.cc (working copy) > @@ -497,14 +497,20 @@ > } > > > -// TODO(181): Implement map patching once loop nesting is tracked on > -// the ARM platform so we can generate inlined fast-case code for > -// array indexing in loops. > -bool KeyedLoadIC::HasInlinedVersion(Address address) { return false; } > -void KeyedLoadIC::ClearInlinedVersion(Address address) { } > -void KeyedLoadIC::PatchInlinedMapCheck(Address address, Object* value) { } > +// TODO(181): Implement map patching once loop nesting is tracked on the > +// ARM platform so we can generate inlined fast-case code loads in > +// loops. > +void LoadIC::ClearInlinedVersion(Address address) {} > +bool LoadIC::PatchInlinedLoad(Address address, Object* map, int offset) { > + return false; > +} > > +void KeyedLoadIC::ClearInlinedVersion(Address address) {} > +bool KeyedLoadIC::PatchInlinedLoad(Address address, Object* map) { > + return false; > +} > > + > Object* KeyedLoadIC_Miss(Arguments args); > > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
