LGTM, though having a reference from the script object to the context and requesting data from the context would be more flexible. We would be able to set the context data only for the contexts we were going to debug. With this implementation we would need to setup context data as early as possible to guarantee the data is already set when the script is being compiled.
http://codereview.chromium.org/111001/diff/1/6 File src/mirror-delay.js (right): http://codereview.chromium.org/111001/diff/1/6#newcode1845 Line 1845: content.push(MakeJSONPair_('sourceLength', it seems that you can switch to JSON.stringify for serialization and get rid of all the custom json serializers(MakeJSONPair_, *ToJSON_, etc) http://codereview.chromium.org/111001 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
