LGTM
http://codereview.chromium.org/109025/diff/1/2 File src/platform-linux.cc (right): http://codereview.chromium.org/109025/diff/1/2#newcode608 Line 608: sample.pc = mcontext.gregs[REG_RIP]; Does the assignment compile, and throw away the upper half of the value silently? If so, I'd prefer an UNIMPLEMENTED() in front of it with a comment saying to not remove it unitl sample.pc allows 64 bits. http://codereview.chromium.org/109025 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
