http://codereview.chromium.org/115021/diff/1011/6 File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/115021/diff/1011/6#newcode35 Line 35: // A light-weight X64 Assembler. On 2009/05/06 11:32:12, Kevin Millikin wrote: > "light-weight" => "lightweight" Done. http://codereview.chromium.org/115021/diff/1011/6#newcode64 Line 64: // kNumRegisters == 16 is not declared yet. On 2009/05/06 11:32:12, Kevin Millikin wrote: > Why not move its declaration? Or it actually makes sense just to make it a > static const in struct Register. Done. http://codereview.chromium.org/115021/diff/1011/6#newcode67 Line 67: // The byte-register distinction of ai32 has dissapeared. On 2009/05/06 11:32:12, Kevin Millikin wrote: > ai32? If it's disappeared, why not just get rid of the function? I want everyone to keep thinking like you do, whenever they see this line, until they do get rid of the function, and verify that whatever calls it is fixed to not use it. http://codereview.chromium.org/115021/diff/1011/6#newcode926 Line 926: #endif // V8_X64_ASSEMBLER_IA32_H_ On 2009/05/06 11:14:31, Dean McNamee wrote: > This still says IA32, it should be X64 Done. http://codereview.chromium.org/115021 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
