LGTM.

http://codereview.chromium.org/115227/diff/1/5
File benchmarks/base.js (right):

http://codereview.chromium.org/115227/diff/1/5#newcode122
Line 122: window.setTimeout(RunStep, 10);
But why?

http://codereview.chromium.org/115227/diff/1/3
File benchmarks/splay.js (right):

http://codereview.chromium.org/115227/diff/1/3#newcode98
Line 98: else splayTree.remove(greatest.key);
Is there any way we can test whether the splay tree is doing what we
expect.   Eg. test the 0th, 1000th and 3141st elements at the end to see
if they are as expected?

http://codereview.chromium.org/115227

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to