http://codereview.chromium.org/115176/diff/4/1003 File src/dtoa-config.c (right):
http://codereview.chromium.org/115176/diff/4/1003#newcode50 Line 50: !defined(__FreeBSD__) && __FLOAT_WORD_ORDER == __BIG_ENDIAN Strictly speaking, we should test the processor architecture rather than the OS to determine the byte order, because an OS may support processors with different byte orders. Common predefined macros for processor architectures currently or soon to be supported by V8: GCC: __i386__, __x86_64__, __arm__ (__ARMEL__ or __ARMEB__) Visual C++: _M_IX86, _M_X64 (older form _M_AMD64) http://codereview.chromium.org/115176/diff/4/1003#newcode75 Line 75: #include "stdlib.h" Nit: use <stdlib.h> for a system header. You may want to combine this with line 65 above. http://codereview.chromium.org/115176 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
