Author: [email protected]
Date: Tue May 12 22:46:51 2009
New Revision: 1926

Modified:
    branches/bleeding_edge/src/runtime.h

Log:
Split the RUNTIME_FUNCTION_LIST_ALWAYS macro into two as this macro is
very large for Visual Studio's
intellisense operation thus causing it to crash.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=11837

Bug=11837

Patch submitted by: [email protected]

Review URL: http://codereview.chromium.org/115287

Modified: branches/bleeding_edge/src/runtime.h
==============================================================================
--- branches/bleeding_edge/src/runtime.h        (original)
+++ branches/bleeding_edge/src/runtime.h        Tue May 12 22:46:51 2009
@@ -37,7 +37,10 @@
  // release and debug mode.
  // This macro should only be used by the macro RUNTIME_FUNCTION_LIST.

-#define RUNTIME_FUNCTION_LIST_ALWAYS(F) \
+// WARNING: RUNTIME_FUNCTION_LIST_ALWAYS_* is a very large macro that  
caused
+// MSVC Intellisense to crash.  It was broken into two macros to work  
around
+// this problem. Please avoid large recursive macros whenever possible.
+#define RUNTIME_FUNCTION_LIST_ALWAYS_1(F) \
    /* Property access */ \
    F(GetProperty, 2) \
    F(KeyedGetProperty, 2) \
@@ -153,8 +156,9 @@
    F(NumberToRadixString, 2) \
    F(NumberToFixed, 2) \
    F(NumberToExponential, 2) \
-  F(NumberToPrecision, 2) \
-  \
+  F(NumberToPrecision, 2)
+
+#define RUNTIME_FUNCTION_LIST_ALWAYS_2(F) \
    /* Reflection */ \
    F(FunctionSetInstanceClassName, 2) \
    F(FunctionSetLength, 2) \
@@ -320,7 +324,8 @@
  // via a native call by name (from within JS code).

  #define RUNTIME_FUNCTION_LIST(F) \
-  RUNTIME_FUNCTION_LIST_ALWAYS(F) \
+  RUNTIME_FUNCTION_LIST_ALWAYS_1(F) \
+  RUNTIME_FUNCTION_LIST_ALWAYS_2(F) \
    RUNTIME_FUNCTION_LIST_DEBUG(F) \
    RUNTIME_FUNCTION_LIST_DEBUGGER_SUPPORT(F)


--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to