It should be OK to remove the loading of Date and RegExp as the use of builtins.X no longer uses stuff in Date (and did no for RegExp anyway). The tests should reveal if that for some odd reason is not the case.
/Søren On Fri, May 15, 2009 at 09:26, <yu...@chromium.org> wrote: > There is a comment at the top of mirror-delay.js that I think can be > removed along with the two lines of code. Can you confirm that? > > > // Touch the RegExp and Date functions to make sure that date-delay.js > and > // regexp-delay.js has been loaded. This is required as the mirrors use > // functions within these files through the builtins object. > RegExp; > Date; > > > > http://codereview.chromium.org/113399/diff/34/49 > File src/debug-delay.js (right): > > http://codereview.chromium.org/113399/diff/34/49#newcode1808 > Line 1808: * @return {Object} JSON formatted object value > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> Returns object - not JSON formatted. >> > > Done. > > http://codereview.chromium.org/113399/diff/34/49#newcode1810 > Line 1810: function SimpleObjectToJSON_(object, mirror_serializer) { > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> I think this function should not have JSON in it's name as it does not >> > return > >> JSON but an object. How about SimpleObjectToProtocolObject? >> > > Done. > > http://codereview.chromium.org/113399/diff/34/49#newcode1835 > Line 1835: * @return {Array} JSON formatted array value > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> Returns array - not JSON formatted. >> > > Done. > > http://codereview.chromium.org/113399/diff/34/49#newcode1837 > Line 1837: function SimpleArrayToJSON_(array, mirror_serializer) { > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> No JSON in name (as above). >> > > Done. > > http://codereview.chromium.org/113399/diff/34/49#newcode1852 > Line 1852: * @return {*} JSON formatted value > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> Return value is not JSON formatted. >> > > Done. > > http://codereview.chromium.org/113399/diff/34/49#newcode1854 > Line 1854: function SimpleValueToJSON_(value, mirror_serializer) { > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> No JSON in name (as above). >> > > Done. > > http://codereview.chromium.org/113399/diff/34/48 > File src/mirror-delay.js (right): > > http://codereview.chromium.org/113399/diff/34/48#newcode1734 > Line 1734: */ > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> Return value is an object. >> > > Done. > > http://codereview.chromium.org/113399/diff/34/48#newcode1962 > Line 1962: * @returns {String} JSON serialization > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> Return value is not string. >> > > Done. > > http://codereview.chromium.org/113399/diff/34/48#newcode2031 > Line 2031: * @returns {String} JSON value > On 2009/05/14 21:10:27, Søren Gjesse wrote: > >> Return value is not always a string. >> > > Done. > > > http://codereview.chromium.org/113399 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
