Soren, Sorry that I didn't have time to look at this until now. The fix you guys came up with is similar to mine except that you guys did the alignment fix in the caller frame and I did mine in the callee frame. Anyway, the fix looks good. I do have one comment below where you can remove one redundant "add" instruction.
Regards, Mark http://codereview.chromium.org/115256/diff/1/4 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/115256/diff/1/4#newcode305 Line 305: add(ip, sp, Operand(r0, LSL, kPointerSizeLog2)); This "add" instruction is functionally equivalent to the "add" at line 297. You can optimize the above 3 instructions slightly into the following 2 instructions: add(ip, sp, Operand(r0, LSL, kPointerSizeLog2)); sub(r6, ip, Operand(kPointerSize)); http://codereview.chromium.org/115256 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
