Reviewers: Søren Gjesse, Description: Tiny fix: initialize TickSample::frames_count with 0.
I suggest that the lack of initialization causes issue 358 to happen. In Profiler::Disengage an empty TickSample is inserted in order to wake up the Profiler thread. Issue reporter claims that crash happens in LogTickEvent function. My guess is that frames_couint receives a wild value. Please review this at http://codereview.chromium.org/113939 Affected files: M src/platform.h Index: src/platform.h diff --git a/src/platform.h b/src/platform.h index f7fdafedd8ba8e4b64d986d55fcd6bf8d7be4c25..4522c7403142e303c6a931fff5d9be6c250b03e8 100644 --- a/src/platform.h +++ b/src/platform.h @@ -493,7 +493,7 @@ class Socket { // TickSample captures the information collected for each sample. class TickSample { public: - TickSample() : pc(0), sp(0), fp(0), state(OTHER) {} + TickSample() : pc(0), sp(0), fp(0), state(OTHER), frames_count(0) {} uintptr_t pc; // Instruction pointer. uintptr_t sp; // Stack pointer. uintptr_t fp; // Frame pointer. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
