Kasper, thanks a lot for review! Some unit tests added.
http://chromereview.prom.corp.google.com/1028098/diff/2002/1010 File src/ia32/stub-cache-ia32.cc (right): http://chromereview.prom.corp.google.com/1028098/diff/2002/1010#newcode365 Line 365: __ push(Immediate(lookup_payload)); // lookup_payload On 2009/05/29 06:16:35, Kasper Lund wrote: > You should probably run the tools/presubmit.py script to catch lint errors. Sorry, done. Troubles fixed. Sorry if I break a common style---didn't do much C++ in Google http://chromereview.prom.corp.google.com/1028098/diff/2002/1010#newcode697 Line 697: __ push(Immediate(Smi::FromInt(JSObject::LOOKUP_IN_HOLDER))); // lookup_payload On 2009/05/29 06:16:35, Kasper Lund wrote: > Line too long. Done. http://chromereview.prom.corp.google.com/1028098/diff/2002/1007 File src/objects.cc (right): http://chromereview.prom.corp.google.com/1028098/diff/2002/1007#newcode5622 Line 5622: PropertyAttributes* attributes) { On 2009/05/29 06:16:35, Kasper Lund wrote: > Line too long? Done. http://chromereview.prom.corp.google.com/1028098/diff/2002/1007#newcode5673 Line 5673: { On 2009/05/29 06:16:35, Kasper Lund wrote: > I think we usually have the { on the case line. Done. http://chromereview.prom.corp.google.com/1028098/diff/2002/1011 File src/stub-cache.cc (right): http://chromereview.prom.corp.google.com/1028098/diff/2002/1011#newcode722 Line 722: Smi* lookup_payload = Smi::cast(args[3]); On 2009/05/29 06:16:35, Kasper Lund wrote: > Payload might be a too generic name. How about something lookup_hint? Good idea, tnx. Adjusted. http://chromereview.prom.corp.google.com/1028098 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
