Reviewers: Kevin Millikin, Message: Hi Kevin,
I would like you to look at this change to be sure that I'm not violating any codegen-related rules. Description: Fix determining of JS lower stack bottom used in profiler's JS stack tracer to work with Chromium. My assumption that log initialization happens somewhere near the stack's bottom is true for V8's sample shell but not true for Chromium, causing many otherwise valid stack addresses to be thrown. The solution proposed is to save stack pointer value for the outermost JS function in ThreadLocalTop similar to c_entry_fp. Implemented only for IA-32. Currently I'm not dealing with profiling on ARM and x86-64 anyway. Please review this at http://codereview.chromium.org/112082 Affected files: M src/ia32/codegen-ia32.cc M src/log.h M src/log.cc M src/top.h M src/top.cc M test/cctest/test-log-ia32.cc --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
