LGTM.
http://codereview.chromium.org/113997/diff/1017/1018 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/113997/diff/1017/1018#newcode127 Line 127: __ movq(rdx, rcx); The move to rdx is superfluous. The 64 bit return value is taken from rax alone. http://codereview.chromium.org/113997/diff/1017/1019 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/113997/diff/1017/1019#newcode402 Line 402: void enter(Immediate size); Good call. Neither Immediate nor ExternalReference has any reason to be passed by reference. http://codereview.chromium.org/113997 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
