LGTM.
http://codereview.chromium.org/114085/diff/2005/1008 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/114085/diff/2005/1008#newcode902 Line 902: ASSERT(!Heap::InNewSpace(*value)); Is this from the ia32 code? I didn't know this. It makes sense, though - we can't fix those up on copying collections. http://codereview.chromium.org/114085/diff/2005/1013 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/114085/diff/2005/1013#newcode48 Line 48: void MacroAssembler::Check(Condition cc, const char* message) { We want this to be inline if the debug check is inside it, don't we? http://codereview.chromium.org/114085 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
