http://codereview.chromium.org/118499/diff/1/3 File src/objects.cc (right):
http://codereview.chromium.org/118499/diff/1/3#newcode5215 Line 5215: int entry = dictionary->FindNumberEntry(index); As we discussed, this is a significant amount of code and we should refactor to share it. http://codereview.chromium.org/118499/diff/1/2 File test/cctest/test-api.cc (right): http://codereview.chromium.org/118499/diff/1/2#newcode2301 Line 2301: templ->SetIndexedPropertyHandler(0, 0, CheckThisIndexedPropertyQuery); It is unclear to me that we are testing the right thing when we only have an indexed query interceptor. Could you do this with a getter and a setter interceptor instead and also test that they are both actually called (and have them both return an empty handle). http://codereview.chromium.org/118499/diff/1/2#newcode2310 Line 2310: for (int i = 0; i < 10; i++) { Why is this in a loop? http://codereview.chromium.org/118499 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
