LGTM.

On Mon, Jun 15, 2009 at 4:24 PM, <[email protected]> wrote:
> Reviewers: Kasper Lund,
>
> Description:
> Use the correct version of CallRuntime in the arm code generator.
>
> This fixes assertion failures in debug mode tests.
>
> Please review this at http://codereview.chromium.org/126128
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected files:
>  M     src/arm/codegen-arm.cc
>
>
> Index: src/arm/codegen-arm.cc
> ===================================================================
> --- src/arm/codegen-arm.cc      (revision 2170)
> +++ src/arm/codegen-arm.cc      (working copy)
> @@ -3419,10 +3419,10 @@
>   LoadAndSpill(args->at(0));
>   switch (op) {
>     case SIN:
> -      __ CallRuntime(Runtime::kMath_sin, 1);
> +      frame_->CallRuntime(Runtime::kMath_sin, 1);
>       break;
>     case COS:
> -      __ CallRuntime(Runtime::kMath_cos, 1);
> +      frame_->CallRuntime(Runtime::kMath_cos, 1);
>       break;
>   }
>   frame_->EmitPush(r0);
>
>
>

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to