LGTM!
http://codereview.chromium.org/126189/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/126189/diff/1/2#newcode2419 Line 2419: // Fast case where the result is a one char string. char -> character http://codereview.chromium.org/126189/diff/1/2#newcode2426 Line 2426: static const char chars[] = "0123456789abcdefghijklmnopqrstuvwxyz"; Should be something like kChars or kCharsMap, right? http://codereview.chromium.org/126189 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
