LGTM

http://codereview.chromium.org/149066/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/149066/diff/1/2#newcode2547
Line 2547: __ movl(scratch.reg(), FieldOperand(result.reg(),
FixedArray::kHeaderSize));
Comment or name offset as first element of fixed array.

http://codereview.chromium.org/149066/diff/1/2#newcode2553
Line 2553: FieldOperand(result.reg(), FixedArray::kHeaderSize +
kPointerSize));
Indentation.
Give the offset a name like kFixedArraySecondElementOffset.

http://codereview.chromium.org/149066

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to