Could you also add this to the X64 platform. It would be based on mul, in the same way. The comments could also be better on X64 - I should know, I wrote them.
http://codereview.chromium.org/150002/diff/1/3 File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/150002/diff/1/3#newcode547 Line 547: void imul(Register reg); // edx:eax = eax * reg. Could you say that edx:eax = signed(eax) * signed(reg), and unsigned for the mul case? That is the point. http://codereview.chromium.org/150002/diff/1/3#newcode548 Line 548: void imul(Register dst, const Operand& src); // dst = dst * src; Why a semicolon? http://codereview.chromium.org/150002/diff/1/3#newcode556 Line 556: void mul(Register src); // edx:eax = eax * reg- What is the - sign at the end for? http://codereview.chromium.org/150002 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
