Rephrased comment and removed bug references. On 2009/06/24 07:38:31, Erik Corry wrote: > LGTM apart from the comments.
> http://codereview.chromium.org/147022/diff/1/2 > File src/heap.cc (right): > http://codereview.chromium.org/147022/diff/1/2#newcode1291 > Line 1291: // gcc-4.4 has problem to generate the correct vtables if the > following > Should be "gcc-4.4 has problems generating..." > I don't understand the comment. It doesn't seem like vtables are being > generated here. > http://codereview.chromium.org/147022/diff/1/2#newcode1300 > Line 1300: // Possible gcc bug: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32327 > Is this relevant? According to the bug this was fixed in gcc-4.3. http://codereview.chromium.org/147022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
