Managed to add some more features to the same branch. Could you do an incremental check?
http://codereview.chromium.org/155087/diff/1/3 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/155087/diff/1/3#newcode348 Line 348: case 0: Done. http://codereview.chromium.org/155087/diff/1/3#newcode1315 Line 1315: const char* NameConverter::NameOfConstant(byte* addr) const { It is. NameConverter is declared elsewhere, and the byte* type is used here to be consistent with the declaration. http://codereview.chromium.org/155087/diff/1/3#newcode1354 Line 1354: DisassemblerX64 d(converter_, false /* do not crash if unimplemented */); The comment explains the meaning of the "false" parameter. I'll convert it to an enum instead. http://codereview.chromium.org/155087/diff/1/3#newcode1358 Line 1358: // The X64 assembler does not currently use constant pools. Removed. http://codereview.chromium.org/155087/diff/1/3#newcode1363 Line 1363: /*static*/void Disassembler::Disassemble(FILE* f, byte* begin, byte* end) { Removed. http://codereview.chromium.org/155087 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
