LGTM once you make it compile on ARM and x64.
http://codereview.chromium.org/140069/diff/5032/6015 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/140069/diff/5032/6015#newcode437 Line 437: // Do tail-call to LoadPropertyByLookupResult End comment with period. http://codereview.chromium.org/140069/diff/5032/6015#newcode492 Line 492: // Under EnterInternalFrame and push(holder) this refers to name End comment with period. http://codereview.chromium.org/140069/diff/5032/6013 File test/cctest/test-api.cc (right): http://codereview.chromium.org/140069/diff/5032/6013#newcode5059 Line 5059: // Now it should be (hopefully) ICed and keep a reference Remove '(hopefully)'. :-) http://codereview.chromium.org/140069/diff/5032/6013#newcode5205 Line 5205: // This test checks that if interceptor provides a function, It looks like this is testing the case where you use the cached function from the prototype chain? http://codereview.chromium.org/140069 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
