LGTM.
http://codereview.chromium.org/155141/diff/1003/1004 File src/ic.cc (right): http://codereview.chromium.org/155141/diff/1003/1004#newcode282 Line 282: if (lookup->IsNotFound() || lookup->type() != INTERCEPTOR || Why did you add the !IsCacheable test here? Is it mostly a quick bailout check, so we can avoid an expensive computation of the LookupResult when we know we'll not really need it? I think it deserves a comment. http://codereview.chromium.org/155141/diff/1003/1004#newcode293 Line 293: if (lookup->IsValid()) { Do you want a non-cacheable bailout check here too? http://codereview.chromium.org/155141 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
