LGTM.

http://codereview.chromium.org/149513/diff/1/10
File tools/tickprocessor.js (right):

http://codereview.chromium.org/149513/diff/1/10#newcode387
Line 387: if (prevEntry && !('end' in prevEntry) &&
The 'end' in prevEntry stuff looks a bit weird to me. I think it would
be more common just to use prevEntry.end, unless you worry about it
being zero.

http://codereview.chromium.org/149513/diff/1/10#newcode410
Line 410: if ('size' in funcInfo) {
Is this because you worry that size can be zero?

http://codereview.chromium.org/149513

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to