Author: sandh...@chromium.org
Date: Tue Jul 14 06:14:59 2009
New Revision: 2457
Modified:
data/benchmarks/v1/run.html
Log:
Added a warning shown if the viewed version is not the current version of
V8 benchmark suite. This change list is only for v1/run.html. I will add
changes for v2, v3 and v4 plus the current one in trunk once this CL
has been accepted.
Review URL: http://codereview.chromium.org/149530
Modified: data/benchmarks/v1/run.html
==============================================================================
--- data/benchmarks/v1/run.html (original)
+++ data/benchmarks/v1/run.html Tue Jul 14 06:14:59 2009
@@ -62,6 +62,16 @@
background-repeat: no-repeat;
border: 1px solid rgb(51, 102, 204);
}
+
+div.warning {
+ background: #ffffd9;
+ border: 1px solid #d2d26a;
+ display: none;
+ margin: 1em 0 2em;
+ padding: 8px;
+ text-align: center;
+}
+
</style>
<script type="text/javascript">
@@ -93,9 +103,35 @@
NotifyScore: AddScore });
}
+function ShowWarningIfObsolete() {
+ // If anything goes wrong we will just catch the exception and no
+ // warning is shown, i.e., no harm is done.
+ try {
+ var xmlhttp;
+ var next_version = parseInt(BenchmarkSuite.version) + 1;
+ var next_version_url = "../v" + next_version + "/run.html";
+ if (window.XMLHttpRequest) {
+ xmlhttp = new window.XMLHttpRequest();
+ } else if (window.ActiveXObject) {
+ xmlhttp = new window.ActiveXObject("Microsoft.XMLHTTP");
+ }
+ xmlhttp.open('GET', next_version_url, true);
+ xmlhttp.onreadystatechange = function() {
+ if (xmlhttp.readyState == 4 && xmlhttp.status == 200) {
+ document.getElementById('obsolete').style.display="block";
+ }
+ };
+ xmlhttp.send(null);
+ } catch(e) {
+ // Ignore exception if check for next version fails.
+ // Hence no warning is displayed.
+ }
+}
+
function Load() {
var version = BenchmarkSuite.version;
document.getElementById("version").innerHTML = version;
+ ShowWarningIfObsolete();
window.setTimeout(Run, 200);
}
</script>
@@ -103,6 +139,13 @@
<body onLoad="Load()">
<div>
<div class="title"><h1>V8 Benchmark Suite - version <span
id="version">?</span></h1></div>
+ <div class="warning" id="obsolete">
+Warning! This is not the latest version of V8 benchmark
+suite. Consider running the
+<a href="http://v8.googlecode.com/svn/data/benchmarks/current/run.html";>
+latest version</a>.
+ </div>
+
<table>
<tr>
<td class="contents">
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
