Reviewers: Mads Ager, Description: Third and hopefully last of thrre CLs to issue a warning when an older version of the benchmark suite is run. This last change updates bleeding_edge.
Please review this at http://codereview.chromium.org/155496 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M benchmarks/run.html M benchmarks/style.css Index: benchmarks/run.html =================================================================== --- benchmarks/run.html (revision 2457) +++ benchmarks/run.html (working copy) @@ -55,9 +55,35 @@ NotifyScore: AddScore }); } +function ShowWarningIfObsolete() { + // If anything goes wrong we will just catch the exception and no + // warning is shown, i.e., no harm is done. + try { + var xmlhttp; + var next_version = parseInt(BenchmarkSuite.version) + 1; + var next_version_url = "../v" + next_version + "/run.html"; + if (window.XMLHttpRequest) { + xmlhttp = new window.XMLHttpRequest(); + } else if (window.ActiveXObject) { + xmlhttp = new window.ActiveXObject("Microsoft.XMLHTTP"); + } + xmlhttp.open('GET', next_version_url, true); + xmlhttp.onreadystatechange = function() { + if (xmlhttp.readyState == 4 && xmlhttp.status == 200) { + document.getElementById('obsolete').style.display="block"; + } + }; + xmlhttp.send(null); + } catch(e) { + // Ignore exception if check for next version fails. + // Hence no warning is displayed. + } +} + function Load() { var version = BenchmarkSuite.version; document.getElementById("version").innerHTML = version; + ShowWarningIfObsolete(); setTimeout(Run, 200); } </script> @@ -65,6 +91,12 @@ <body onload="Load()"> <div> <div class="title"><h1>V8 Benchmark Suite - version <span id="version">?</span></h1></div> + <div class="warning" id="obsolete"> +Warning! This is not the latest version of V8 benchmark +suite. Consider running the +<a href="http://v8.googlecode.com/svn/data/benchmarks/current/run.html";> +latest version</a>. + </div> <table> <tr> <td class="contents"> Index: benchmarks/style.css =================================================================== --- benchmarks/style.css (revision 2457) +++ benchmarks/style.css (working copy) @@ -55,6 +55,15 @@ border: 1px solid rgb(51, 102, 204); } +div.warning { + background: #ffffd9; + border: 1px solid #d2d26a; + display: none; + margin: 1em 0 2em; + padding: 8px; + text-align: center; +} + #status { text-align: center; margin-top: 50px; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
