LGTM. My mistake - I did the change and then ran off without checking the bots. Sorry about that.
-- Mads On Mon, Jul 13, 2009 at 11:59 PM, Kevin Millikin<kmilli...@chromium.org> wrote: > > LGTM. > > On 7/14/09, kasp...@chromium.org <kasp...@chromium.org> wrote: >> Reviewers: Kevin Millikin, >> >> Description: >> Update test expectations because we've decided to allow RegExps >> to be called as functions. See http://codereview.chromium.org/155453. >> >> tbr=kmilli...@chromium.org >> >> Please review this at http://codereview.chromium.org/155488 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M test/mozilla/mozilla.status >> >> >> Index: test/mozilla/mozilla.status >> =================================================================== >> --- test/mozilla/mozilla.status (revision 2452) >> +++ test/mozilla/mozilla.status (working copy) >> @@ -321,10 +321,6 @@ >> js1_5/Regress/regress-172699: FAIL_OK >> >> >> -# Calls regexp objects with function call syntax; non-ECMA behavior. >> -js1_2/Objects/toString-001: FAIL_OK >> - >> - >> # Assumes that the prototype of a function is enumerable. Non-ECMA, >> # see section 15.3.3.1, page 86. >> ecma/GlobalObject/15.1.2.2-1: FAIL_OK >> @@ -338,6 +334,7 @@ >> # Tests that rely on specific details of function decompilation or >> # print strings for errors. Non-ECMA behavior. >> js1_2/function/tostring-2: FAIL_OK >> +js1_2/Objects/toString-001: FAIL_OK >> js1_5/Exceptions/regress-332472: FAIL_OK >> js1_5/Regress/regress-173067: FAIL_OK >> js1_5/Regress/regress-355556: FAIL_OK >> @@ -561,23 +558,11 @@ >> ecma_3/Function/regress-137181: FAIL >> >> >> -# Calls regexp objects with function call syntax; non-ECMA behavior. >> -ecma_2/RegExp/regress-001: FAIL >> -js1_2/regexp/regress-6359: FAIL >> -js1_2/regexp/regress-9141: FAIL >> -js1_5/Regress/regress-224956: FAIL >> -js1_5/Regress/regress-325925: FAIL >> -js1_2/regexp/simple_form: FAIL >> - >> - >> # Tests that rely on specific details of function decompilation or >> # print strings for errors. Non-ECMA behavior. >> js1_4/Regress/function-003: FAIL >> >> >> -# Relies on JavaScript 1.2 / 1.3 deprecated features. >> -js1_2/function/regexparg-1: FAIL >> - >> # 'export' and 'import' are not keywords in V8. >> ecma_2/Exceptions/lexical-010: FAIL >> ecma_2/Exceptions/lexical-022: FAIL >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
